Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 599633004: Android WebView: fix missing an invalidate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2125
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/hardware_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index b0c813100edb1a6662e5aebe6d9593cdd7182d13..282b5fc822c47552c80e1915f60228521fe8d2ec 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -244,8 +244,10 @@ bool BrowserViewRenderer::OnDrawHardware(jobject java_canvas) {
if (!compositor_)
return false;
- if (last_on_draw_global_visible_rect_.IsEmpty())
+ if (last_on_draw_global_visible_rect_.IsEmpty()) {
+ shared_renderer_state_->SetForceInvalidateOnNextDrawGL(true);
return client_->RequestDrawGL(java_canvas, false);
+ }
if (!hardware_enabled_) {
hardware_enabled_ = compositor_->InitializeHwDraw();
@@ -307,9 +309,12 @@ bool BrowserViewRenderer::OnDrawHardware(jobject java_canvas) {
void BrowserViewRenderer::UpdateParentDrawConstraints() {
// Post an invalidate if the parent draw constraints are stale and there is
// no pending invalidate.
- if (!parent_draw_constraints_.Equals(
- shared_renderer_state_->ParentDrawConstraints()))
+ if (shared_renderer_state_->NeedsForceInvalidateOnNextDrawGL() ||
+ !parent_draw_constraints_.Equals(
+ shared_renderer_state_->ParentDrawConstraints())) {
+ shared_renderer_state_->SetForceInvalidateOnNextDrawGL(false);
EnsureContinuousInvalidation(true);
+ }
}
void BrowserViewRenderer::ReturnUnusedResource(scoped_ptr<DrawGLInput> input) {
« no previous file with comments | « no previous file | android_webview/browser/hardware_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698