Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 599503002: Remove underscores from mode identifiers. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove underscores from mode identifiers. Underscore is used as a field separator sometimes when parsing the task name into a list of config, mode, etc. (This itself is dumb and TODO(mtklein): fix.) Underscores in the field names will really mess that up, both in directories generated from human-mode -w, and in the .json file. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e51ac563de24ed4b25fde97c225580a30a55e9ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M dm/DMPipeTask.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M dm/DMSerializeTask.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years, 3 months ago (2014-09-23 15:29:57 UTC) #2
jcgregorio
On 2014/09/23 15:29:57, mtklein wrote: LGTM
6 years, 3 months ago (2014-09-23 15:32:22 UTC) #3
mtklein
lgtm
6 years, 3 months ago (2014-09-23 15:33:43 UTC) #5
mtklein
On 2014/09/23 15:33:43, mtklein wrote: > lgtm Oops. Well, it does.
6 years, 3 months ago (2014-09-23 15:33:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599503002/1
6 years, 3 months ago (2014-09-23 15:34:03 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 16:20:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as e51ac563de24ed4b25fde97c225580a30a55e9ca

Powered by Google App Engine
This is Rietveld 408576698