Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: dm/DMPipeTask.cpp

Issue 599503002: Remove underscores from mode identifiers. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | dm/DMSerializeTask.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #include "DMPipeTask.h" 1 #include "DMPipeTask.h"
2 #include "DMUtil.h" 2 #include "DMUtil.h"
3 #include "DMWriteTask.h" 3 #include "DMWriteTask.h"
4 4
5 #include "SamplePipeControllers.h" 5 #include "SamplePipeControllers.h"
6 #include "SkCommandLineFlags.h" 6 #include "SkCommandLineFlags.h"
7 #include "SkGPipe.h" 7 #include "SkGPipe.h"
8 8
9 DEFINE_bool(pipe, true, "If true, check several pipe variants against the refere nce bitmap."); 9 DEFINE_bool(pipe, true, "If true, check several pipe variants against the refere nce bitmap.");
10 10
11 namespace DM { 11 namespace DM {
12 12
13 static uint32_t get_flags(PipeTask::Mode mode) { 13 static uint32_t get_flags(PipeTask::Mode mode) {
14 uint32_t flags = 0; 14 uint32_t flags = 0;
15 if (mode != PipeTask::kInProcess_Mode) { 15 if (mode != PipeTask::kInProcess_Mode) {
16 flags |= SkGPipeWriter::kCrossProcess_Flag; 16 flags |= SkGPipeWriter::kCrossProcess_Flag;
17 } 17 }
18 if (mode == PipeTask::kSharedAddress_Mode) { 18 if (mode == PipeTask::kSharedAddress_Mode) {
19 flags |= SkGPipeWriter::kSharedAddressSpace_Flag; 19 flags |= SkGPipeWriter::kSharedAddressSpace_Flag;
20 } 20 }
21 return flags; 21 return flags;
22 } 22 }
23 23
24 static const char* get_name(const uint32_t flags) { 24 static const char* get_name(const uint32_t flags) {
25 if (flags & SkGPipeWriter::kCrossProcess_Flag && 25 if (flags & SkGPipeWriter::kCrossProcess_Flag &&
26 flags & SkGPipeWriter::kSharedAddressSpace_Flag) { 26 flags & SkGPipeWriter::kSharedAddressSpace_Flag) {
27 return "shared_address_space_pipe"; 27 return "shared-address-space-pipe";
28 } else if (flags & SkGPipeWriter::kCrossProcess_Flag) { 28 } else if (flags & SkGPipeWriter::kCrossProcess_Flag) {
29 return "cross_process_pipe"; 29 return "cross-process-pipe";
30 } else { 30 } else {
31 return "pipe"; 31 return "pipe";
32 } 32 }
33 } 33 }
34 34
35 PipeTask::PipeTask(const Task& parent, 35 PipeTask::PipeTask(const Task& parent,
36 skiagm::GM* gm, 36 skiagm::GM* gm,
37 SkBitmap reference, 37 SkBitmap reference,
38 Mode mode) 38 Mode mode)
39 : CpuTask(parent) 39 : CpuTask(parent)
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 return true; 74 return true;
75 } 75 }
76 if (fFlags == SkGPipeWriter::kCrossProcess_Flag && 76 if (fFlags == SkGPipeWriter::kCrossProcess_Flag &&
77 fGM->getFlags() & skiagm::GM::kSkipPipeCrossProcess_Flag) { 77 fGM->getFlags() & skiagm::GM::kSkipPipeCrossProcess_Flag) {
78 return true; 78 return true;
79 } 79 }
80 return false; 80 return false;
81 } 81 }
82 82
83 } // namespace DM 83 } // namespace DM
OLDNEW
« no previous file with comments | « no previous file | dm/DMSerializeTask.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698