Issue 599493003: Revert "Add support for EGL on linux"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 599493003: Revert "Add support for EGL on linux" (Closed)

Created:
6 years, 3 months ago by borenet

Modified:
6 years, 3 months ago

Reviewers:
bsalomon, djsollen

CC:
reviews_skia.org, derekf

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert "Add support for EGL on linux" This reverts commit 1cea736c3280b6f0553e3eaa598e41370b305b57. Caused segfaults on all Android devices TBR=djsollen,bsalomon NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e33985a56d4aa41b72b0e266897aa4f0100d6d2e

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -239 lines)			Patch
M	gyp/common_variables.gypi	View	5 chunks	+0 lines, -7 lines	0 comments	Download
M	gyp/gpu.gyp	View	4 chunks	+0 lines, -24 lines	0 comments	Download
M	gyp/gpu.gypi	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	include/gpu/gl/SkNativeGLContext.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	src/gpu/gl/android/SkNativeGLContext_android.cpp	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	src/gpu/gl/egl/GrGLCreateNativeInterface_egl.cpp	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	src/gpu/gl/egl/SkNativeGLContext_egl.cpp	View	1 chunk	+0 lines, -182 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599493003/1

6 years, 3 months ago (2014-09-24 12:31:02 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 12:31:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as e33985a56d4aa41b72b0e266897aa4f0100d6d2e