Add support for EGL on linux

Add support for EGL on linux

Allow setting skia_egl=1 to build skia against EGL instead of GLX on unix

Committed: https://skia.googlesource.com/skia/+/1cea736c3280b6f0553e3eaa598e41370b305b57

[derekf, 2014-09-15 22:13:16]

Patchset #1 (id:1) has been deleted

[derekf, 2014-09-15 22:13:26]

Patchset #1 (id:20001) has been deleted

[derekf, 2014-09-15 22:13:32]

Patchset #1 (id:40001) has been deleted

[derekf, 2014-09-15 22:13:38]

Patchset #1 (id:60001) has been deleted

[derekf, 2014-09-15 22:16:15]

derekf@osg.samsung.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com

[derekf, 2014-09-15 22:22:15]

My intent with this patch set is to allow building skia for linux with EGL
instead of GLX - I've done this by renaming the android's SkNativeGLContext and
using it for all EGL builds as it appears to contain nothing android specific.

Sorry if I've picked reviewers poorly.

[derekf, 2014-09-23 18:27:04]

On 2014/09/15 22:22:15, derekf wrote:
> My intent with this patch set is to allow building skia for linux with EGL
> instead of GLX - I've done this by renaming the android's SkNativeGLContext
and
> using it for all EGL builds as it appears to contain nothing android specific.
> 
> Sorry if I've picked reviewers poorly.

Hi - trying to gauge interest in this, as I have a couple of other patches that
follow from it.

[bsalomon, 2014-09-23 18:55:46]

Seems like a good idea to me, but I think we should make egl it's own directory
rather than using unix_egl.

[derekf, 2014-09-23 20:02:51]

PTAL

[djsollen, 2014-09-23 20:18:27]

https://codereview.chromium.org/543363004/diff/100001/include/gpu/gl/SkNative...
File include/gpu/gl/SkNativeGLContext.h (right):

https://codereview.chromium.org/543363004/diff/100001/include/gpu/gl/SkNative...
include/gpu/gl/SkNativeGLContext.h:38: #elif defined(SK_BUILD_FOR_ANDROID) ||
defined(SK_BUILD_FOR_NACL) || defined(SK_EGL)
should we just replace SK_BUILD_FOR_ANDROID/NACL with SK_EGL and make sure we
define SK_EGL for those build types?

[derekf, 2014-09-23 21:03:49]

On 2014/09/23 20:18:27, djsollen wrote:
>
https://codereview.chromium.org/543363004/diff/100001/include/gpu/gl/SkNative...
> File include/gpu/gl/SkNativeGLContext.h (right):
> 
>
https://codereview.chromium.org/543363004/diff/100001/include/gpu/gl/SkNative...
> include/gpu/gl/SkNativeGLContext.h:38: #elif defined(SK_BUILD_FOR_ANDROID) ||
> defined(SK_BUILD_FOR_NACL) || defined(SK_EGL)
> should we just replace SK_BUILD_FOR_ANDROID/NACL with SK_EGL and make sure we
> define SK_EGL for those build types?

Sure.  It'll make the gyp logic a little more complicated since NACL doesn't
want *_egl.cpp but I think it'll make the source look nicer.

Will upload a new patch set shortly.

[derekf, 2014-09-23 21:18:22]

Patch set 3 removes SK_BUILD_NACL and SK_BUILD_ANDROID tests from
SkNativeGLContext.h and replaces them with SK_EGL

skia_egl (and therefor SK_EGL) is now set for nacl and android builds.

[bsalomon, 2014-09-23 21:30:07]

lgtm

[derekf, 2014-09-23 22:08:03]

The CQ bit was checked by derekf@osg.samsung.com

[commit-bot: I haz the power, 2014-09-23 22:09:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/543363004/120001

[commit-bot: I haz the power, 2014-09-23 22:17:40]

Committed patchset #3 (id:120001) as 1cea736c3280b6f0553e3eaa598e41370b305b57

[borenet, 2014-09-24 12:30:38]

On 2014/09/23 22:17:40, I haz the power (commit-bot) wrote:
> Committed patchset #3 (id:120001) as 1cea736c3280b6f0553e3eaa598e41370b305b57

Reverted in https://codereview.chromium.org/599493003/ due to segfaults on all
Android devices.