Memory allocation for WriteInto is not proper.

Memory allocation for WriteInto is not proper.

Memory for WriteInto() should be greater than the url length,
As in the WriteInto() it reserve the memory of size 'length_with_null'
and then resize it to "length_with_null-1'
Chnage done to give memory 1 greater than the url length size.

BUG=417732
Committed: https://crrev.com/64d81572b36829960001fc34314604f71c6bd50a
Cr-Commit-Position: refs/heads/master@{#297102}

[Deepak, 2014-09-25 15:33:52]

deepak.m1@samsung.com changed reviewers:
+ gene@chromium.org, jam@chromium.org

[Deepak, 2014-09-25 15:33:52]

PTAL

[gene, 2014-09-25 18:16:58]

lgtm

[gene, 2014-09-25 18:18:56]

https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc#...
pdf/pdfium/pdfium_engine.cc:3404: doc, "Creator", WriteInto(&creator,
buffer_bytes), buffer_bytes + 1);
Are you sure, you are adding +1 in the GetMetaText(), and NOT in WriteInto() ???

[Deepak, 2014-09-26 03:02:38]

PTAL

https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc#...
pdf/pdfium/pdfium_engine.cc:3404: doc, "Creator", WriteInto(&creator,
buffer_bytes), buffer_bytes + 1);
On 2014/09/25 18:18:56, gene wrote:
> Are you sure, you are adding +1 in the GetMetaText(), and NOT in WriteInto()
???

Thanks gene for review,After close examination I found that we don't need to
increase the buffer_bytes here, As when we make 

  size_t buffer_bytes = FPDF_GetMetaText(doc, "Creator", NULL, 0);
then it returns me len+2.

And later when we again call 

FPDF_GetMetaText(
        doc, "Creator", WriteInto(&creator, buffer_bytes), buffer_bytes);
Then it copied only len bytes, and keeping last 2 bytes as 0.

I have done changes and raises patch again.
Thanks again.

[Deepak, 2014-09-26 03:16:52]

On 2014/09/26 03:02:38, Deepak wrote:
> PTAL
> 
> https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc
> File pdf/pdfium/pdfium_engine.cc (right):
> 
>
https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc#...
> pdf/pdfium/pdfium_engine.cc:3404: doc, "Creator", WriteInto(&creator,
> buffer_bytes), buffer_bytes + 1);
> On 2014/09/25 18:18:56, gene wrote:
> > Are you sure, you are adding +1 in the GetMetaText(), and NOT in WriteInto()
> ???
> 
> Thanks gene for review,After close examination I found that we don't need to
> increase the buffer_bytes here, As when we make 
> 
>   size_t buffer_bytes = FPDF_GetMetaText(doc, "Creator", NULL, 0);
> then it returns me len+2.
> 
> And later when we again call 
> 
> FPDF_GetMetaText(
>         doc, "Creator", WriteInto(&creator, buffer_bytes), buffer_bytes);
> Then it copied only len bytes, and keeping last 2 bytes as 0.
> 
> I have done changes and raises patch again.
> Thanks again.

Little misunderstanding in my last comment, anyway we require one more memory
for null termination.
Changes done and pushed again.

[Deepak, 2014-09-26 04:38:08]

On 2014/09/26 03:16:52, Deepak wrote:
> On 2014/09/26 03:02:38, Deepak wrote:
> > PTAL
> > 
> > https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc
> > File pdf/pdfium/pdfium_engine.cc (right):
> > 
> >
>
https://codereview.chromium.org/599373003/diff/1/pdf/pdfium/pdfium_engine.cc#...
> > pdf/pdfium/pdfium_engine.cc:3404: doc, "Creator", WriteInto(&creator,
> > buffer_bytes), buffer_bytes + 1);
> > On 2014/09/25 18:18:56, gene wrote:
> > > Are you sure, you are adding +1 in the GetMetaText(), and NOT in
WriteInto()
> > ???
> > 
> > Thanks gene for review,After close examination I found that we don't need to
> > increase the buffer_bytes here, As when we make 
> > 
> >   size_t buffer_bytes = FPDF_GetMetaText(doc, "Creator", NULL, 0);
> > then it returns me len+2.
> > 
> > And later when we again call 
> > 
> > FPDF_GetMetaText(
> >         doc, "Creator", WriteInto(&creator, buffer_bytes), buffer_bytes);
> > Then it copied only len bytes, and keeping last 2 bytes as 0.
> > 
> > I have done changes and raises patch again.
> > Thanks again.
> 
> Little misunderstanding in my last comment, anyway we require one more memory
byte
> for null termination.
> Changes done and pushed again.
This will make usage of writeInto() consistent at all places.

[gene, 2014-09-26 18:25:42]

lgtm

[jam, 2014-09-27 00:56:57]

jam@chromium.org changed reviewers:
- jam@chromium.org

[jam, 2014-09-27 00:57:10]

On 2014/09/26 18:25:42, gene wrote:
> lgtm

removing myself as reviewer since gene is an owner here

[Deepak, 2014-09-27 03:17:57]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2014-09-27 03:19:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599373003/60001

[commit-bot: I haz the power, 2014-09-27 04:11:42]

Committed patchset #4 (id:60001) as d7e417ecb086306fdfe80d5bddd491271e53529c

[commit-bot: I haz the power, 2014-09-27 04:12:40]

Patchset 4 (id:??) landed as
https://crrev.com/64d81572b36829960001fc34314604f71c6bd50a
Cr-Commit-Position: refs/heads/master@{#297102}