pdf/pdfium/pdfium_engine.cc - Issue 599373003: Memory allocation for WriteInto is not proper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 599373003: Memory allocation for WriteInto is not proper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index 42f69e7bf2a9bb30154015f0bd2269ff6f0a908b..7b0726ac0bd2831884302e51284bc27d01b46489 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -3400,8 +3400,8 @@ bool PDFiumEngineExports::RenderPDFPageToDC(const void* pdf_buffer,

base::string16 creator;

size_t buffer_bytes = FPDF_GetMetaText(doc, "Creator", NULL, 0);

if (buffer_bytes > 1) {

- FPDF_GetMetaText(doc, "Creator", WriteInto(&creator, buffer_bytes),

- buffer_bytes);

+ FPDF_GetMetaText(

+ doc, "Creator", WriteInto(&creator, buffer_bytes + 1), buffer_bytes);

}

bool use_bitmap = false;

if (StartsWith(creator, L"cairo", false))

« no previous file with comments | « no previous file | pdf/pdfium/pdfium_page.cc » ('j') | no next file with comments »