Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 599143002: Switch DCHECK() guarding against URLRequest::Read() failure (Closed)

Created:
6 years, 2 months ago by Randy Smith (Not in Mondays)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@DoLoopSpin
Project:
chromium
Visibility:
Public.

Description

Switch DCHECK() guarding against URLRequest::Read() failure in SdchDictionaryFetcher to DLOG(FATAL). BUG=416639 R=rch@chromium.org Committed: https://crrev.com/a400e5663a1c116a53296777d11633163484b501 Cr-Commit-Position: refs/heads/master@{#296465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/base/sdch_dictionary_fetcher.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Randy Smith (Not in Mondays)
Ryan: PTAL?
6 years, 2 months ago (2014-09-24 16:24:36 UTC) #1
Ryan Hamilton
LGTM. Sorry for being so nitty!
6 years, 2 months ago (2014-09-24 17:54:49 UTC) #2
Randy Smith (Not in Mondays)
On 2014/09/24 17:54:49, Ryan Hamilton wrote: > LGTM. Sorry for being so nitty! No worries. ...
6 years, 2 months ago (2014-09-24 17:58:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599143002/1
6 years, 2 months ago (2014-09-24 17:58:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 717a1096480c87e9b029fd112c078dee6e72e244
6 years, 2 months ago (2014-09-24 18:05:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a400e5663a1c116a53296777d11633163484b501 Cr-Commit-Position: refs/heads/master@{#296465}
6 years, 2 months ago (2014-09-24 18:06:30 UTC) #7
Ryan Hamilton
6 years, 2 months ago (2014-09-24 18:42:10 UTC) #8
On Wed, Sep 24, 2014 at 10:58 AM, <rdsmith@chromium.org> wrote:

> No worries.  Your prize was an extra code review :-}.
>

​I win!​

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698