Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: net/base/sdch_dictionary_fetcher.cc

Issue 599143002: Switch DCHECK() guarding against URLRequest::Read() failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DoLoopSpin
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/sdch_dictionary_fetcher.cc
diff --git a/net/base/sdch_dictionary_fetcher.cc b/net/base/sdch_dictionary_fetcher.cc
index 4a45f107e3e8b48270ddac282525b7141ae3a819..8d08b9a678afabacd828ee0b8efb70989362fabf 100644
--- a/net/base/sdch_dictionary_fetcher.cc
+++ b/net/base/sdch_dictionary_fetcher.cc
@@ -203,13 +203,14 @@ int SdchDictionaryFetcher::DoRead(int rv) {
if (current_request_->status().is_io_pending())
return ERR_IO_PENDING;
- DCHECK_NE(current_request_->status().error(), OK);
if (current_request_->status().error() == OK) {
// This "should never happen", but if it does the result will be
// an infinite loop. It's not clear how to handle a read failure
// without a promise to invoke the callback at some point in the future,
// so the request is failed.
SdchManager::SdchErrorRecovery(SdchManager::DICTIONARY_FETCH_READ_FAILED);
+ DLOG(FATAL) <<
+ "URLRequest::Read() returned false without IO pending or error!";
return ERR_FAILED;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698