Fix android presubmit errors.

Fix android presubmit errors.

Modify android code to avoid depending on side effects of previous
steps when in BUILDBOT_TESTING mode.  This is causing failure on
chromium_presubmit.  Fix some pylint warnings.

BUG=317585
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236522

[bulach, 2013-11-14 19:50:03]

lgtm, thanks for the quick response! one suggestion below, not sure if it makes
sense..

https://chromiumcodereview.appspot.com/59903026/diff/140001/build/android/adb...
File build/android/adb_logcat_printer.py (right):

https://chromiumcodereview.appspot.com/59903026/diff/140001/build/android/adb...
build/android/adb_logcat_printer.py:154: parser =
optparse.OptionParser(usage='Usage: %prog [options] <log dir>')
nit: while at it, it seems a bit confusing to have --output-path and <log dir>..
any chance of having just one, or explicit options for both?

[Isaac (away), 2013-11-21 11:11:33]

https://chromiumcodereview.appspot.com/59903026/diff/140001/build/android/adb...
File build/android/adb_logcat_printer.py (right):

https://chromiumcodereview.appspot.com/59903026/diff/140001/build/android/adb...
build/android/adb_logcat_printer.py:154: parser =
optparse.OptionParser(usage='Usage: %prog [options] <log dir>')
On 2013/11/14 19:50:04, bulach wrote:
> nit: while at it, it seems a bit confusing to have --output-path and <log
dir>..
> any chance of having just one, or explicit options for both?

--output-path is optional, while the extra arg is always required.  I don't
usually override nits, but I really want to fix the android presubmit, and I
also believe this whole file's api is bad and will need to be redone.  WDYT?

[commit-bot: I haz the power, 2013-11-21 11:15:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/59903026/140001

[commit-bot: I haz the power, 2013-11-21 13:49:04]

Change committed as 236522