build/android/buildbot/bb_device_steps.py - Issue 59903026: Fix android presubmit errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 59903026: Fix android presubmit errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix_typo Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/buildbot/bb_device_steps.py

diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py

index 80342f298443861b3a4d623950ca5fc4eabad67e..d9424c0a53fc3e216c0e21c2bffea7038804c272 100755

--- a/build/android/buildbot/bb_device_steps.py

+++ b/build/android/buildbot/bb_device_steps.py

@@ -511,11 +511,8 @@ def LogcatDump(options):

# Print logcat, kill logcat monitor

bb_annotations.PrintNamedStep('logcat_dump')

logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log')

- with open(logcat_file, 'w') as f:

- RunCmd([

- os.path.join(CHROME_SRC_DIR, 'build', 'android',

- 'adb_logcat_printer.py'),

- LOGCAT_DIR], stdout=f)

+ RunCmd([SrcPath('build' , 'android', 'adb_logcat_printer.py'),

+ '--output-path', logcat_file, LOGCAT_DIR])

RunCmd(['cat', logcat_file])