android_webview/native/intercepted_request_data_impl.h - Issue 59903011: [android_webview] Fix UAF in request interception code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/intercepted_request_data_impl.h

Issue 59903011: [android_webview] Fix UAF in request interception code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/intercepted_request_data_impl.h

diff --git a/android_webview/native/intercepted_request_data_impl.h b/android_webview/native/intercepted_request_data_impl.h

index 457bda94b56d4c2c887a7c85eec020db4a10291e..0246569e80d84a8fb16f595763178d0e99d2dbf1 100644

--- a/android_webview/native/intercepted_request_data_impl.h

+++ b/android_webview/native/intercepted_request_data_impl.h

@@ -25,10 +25,6 @@ class InterceptedRequestDataImpl : public InterceptedRequestData {

virtual bool GetMimeType(JNIEnv* env, std::string* mime_type) const;

virtual bool GetCharset(JNIEnv* env, std::string* charset) const;

- virtual net::URLRequestJob* CreateJobFor(

- net::URLRequest* request,

- net::NetworkDelegate* network_delegate) const OVERRIDE;

private:

base::android::ScopedJavaGlobalRef<jobject> java_object_;