Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: android_webview/native/intercepted_request_data_impl.h

Issue 59903011: [android_webview] Fix UAF in request interception code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_NATIVE_INTERCEPTED_REQUEST_DATA_IMPL_H_ 5 #ifndef ANDROID_WEBVIEW_NATIVE_INTERCEPTED_REQUEST_DATA_IMPL_H_
6 #define ANDROID_WEBVIEW_NATIVE_INTERCEPTED_REQUEST_DATA_IMPL_H_ 6 #define ANDROID_WEBVIEW_NATIVE_INTERCEPTED_REQUEST_DATA_IMPL_H_
7 7
8 #include "android_webview/browser/intercepted_request_data.h" 8 #include "android_webview/browser/intercepted_request_data.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 12
13 namespace android_webview { 13 namespace android_webview {
14 14
15 class InputStream; 15 class InputStream;
16 16
17 class InterceptedRequestDataImpl : public InterceptedRequestData { 17 class InterceptedRequestDataImpl : public InterceptedRequestData {
18 public: 18 public:
19 // It is expected that |obj| is an instance of the Java-side 19 // It is expected that |obj| is an instance of the Java-side
20 // org.chromium.android_webview.InterceptedRequestData class. 20 // org.chromium.android_webview.InterceptedRequestData class.
21 InterceptedRequestDataImpl(const base::android::JavaRef<jobject>& obj); 21 InterceptedRequestDataImpl(const base::android::JavaRef<jobject>& obj);
22 virtual ~InterceptedRequestDataImpl(); 22 virtual ~InterceptedRequestDataImpl();
23 23
24 virtual scoped_ptr<InputStream> GetInputStream(JNIEnv* env) const; 24 virtual scoped_ptr<InputStream> GetInputStream(JNIEnv* env) const;
25 virtual bool GetMimeType(JNIEnv* env, std::string* mime_type) const; 25 virtual bool GetMimeType(JNIEnv* env, std::string* mime_type) const;
26 virtual bool GetCharset(JNIEnv* env, std::string* charset) const; 26 virtual bool GetCharset(JNIEnv* env, std::string* charset) const;
27 27
28 virtual net::URLRequestJob* CreateJobFor(
29 net::URLRequest* request,
30 net::NetworkDelegate* network_delegate) const OVERRIDE;
31
32 private: 28 private:
33 base::android::ScopedJavaGlobalRef<jobject> java_object_; 29 base::android::ScopedJavaGlobalRef<jobject> java_object_;
34 30
35 DISALLOW_COPY_AND_ASSIGN(InterceptedRequestDataImpl); 31 DISALLOW_COPY_AND_ASSIGN(InterceptedRequestDataImpl);
36 }; 32 };
37 33
38 bool RegisterInterceptedRequestData(JNIEnv* env); 34 bool RegisterInterceptedRequestData(JNIEnv* env);
39 35
40 } // namespace android_webview 36 } // namespace android_webview
41 37
42 #endif // ANDROID_WEBVIEW_NATIVE_INTERCEPTED_REQUEST_DATA_IMPL_H_ 38 #endif // ANDROID_WEBVIEW_NATIVE_INTERCEPTED_REQUEST_DATA_IMPL_H_
OLDNEW
« no previous file with comments | « android_webview/native/android_protocol_handler.cc ('k') | android_webview/native/intercepted_request_data_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698