Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 598963002: Add support for Float32 representation changes. (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add support for Float32 representation changes. R=bmeurer@chromium.org BUG=v8:3589 LOG=n Committed: https://code.google.com/p/v8/source/detail?r=24180

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -32 lines) Patch
M src/compiler/js-graph.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +1 line, -13 lines 0 comments Download
M src/compiler/representation-change.h View 1 8 chunks +70 lines, -18 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 5 chunks +52 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
6 years, 3 months ago (2014-09-24 11:27:09 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/598963002/diff/1/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/598963002/diff/1/src/compiler/representation-change.h#newcode124 src/compiler/representation-change.h:124: return jsgraph()->Float32Constant(OpParameter<float>(node)); DoubleToFloat32(OpParameter<double>(node)) https://codereview.chromium.org/598963002/diff/1/src/compiler/representation-change.h#newcode128 src/compiler/representation-change.h:128: return jsgraph()->Float32Constant(static_cast<float>(value)); is that ...
6 years, 3 months ago (2014-09-24 11:43:31 UTC) #2
titzer
https://codereview.chromium.org/598963002/diff/1/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/598963002/diff/1/src/compiler/representation-change.h#newcode124 src/compiler/representation-change.h:124: return jsgraph()->Float32Constant(OpParameter<float>(node)); On 2014/09/24 11:43:31, Benedikt Meurer wrote: > ...
6 years, 3 months ago (2014-09-24 11:52:40 UTC) #3
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-24 11:52:56 UTC) #4
titzer
6 years, 3 months ago (2014-09-24 11:55:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as 24180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698