Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 598963002: Add support for Float32 representation changes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/compiler/representation-change.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index 8fe899cd2fd3ef14a46d6e859d33db022b6e566c..8d4bd205254690b29723c8aa5465c43df54e4f2a 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -559,14 +559,6 @@ Reduction JSTypedLowering::ReduceJSLoadProperty(Node* node) {
graph()->NewNode(simplified()->LoadElement(element_access), elements,
key, jsgraph()->Uint32Constant(length),
NodeProperties::GetEffectInput(node));
- // TODO(titzer): Remove this hack once float32 is properly supported in
- // simplified lowering.
- if (element_access.machine_type == kRepFloat32) {
- Node* change =
- graph()->NewNode(machine()->ChangeFloat32ToFloat64(), value);
- NodeProperties::ReplaceWithValue(node, change, value);
- return Changed(value);
- }
return ReplaceEagerly(node, value);
}
return NoChange();
@@ -610,11 +602,7 @@ Reduction JSTypedLowering::ReduceJSStoreProperty(Node* node) {
NodeProperties::GetControlInput(node));
Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
- // TODO(titzer): Remove this hack once float32 is properly supported in
- // simplified lowering.
- if (element_access.machine_type == kRepFloat32) {
- value = graph()->NewNode(machine()->TruncateFloat64ToFloat32(), value);
- }
+
Node* store =
graph()->NewNode(simplified()->StoreElement(element_access), elements,
key, jsgraph()->Uint32Constant(length), value,
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/compiler/representation-change.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698