blink::shutdown() should not touch a message loop

blink::shutdown() should not touch a message loop

We're planning to destruct a message loop of the main thread
before Chromium calls blink::shutdown() (See https://codereview.chromium.org/583043005/).
Thus blink::shutdown() is not allowed to touch the message loop.
This CL removes code in blink::shutdown() that touches the message loop.

BUG=411026
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182655

[haraken, 2014-09-25 06:23:43]

haraken@chromium.org changed reviewers:
+ jamesr@chromium.org, oilpan-reviews@chromium.org

[haraken, 2014-09-25 06:23:57]

jamesr@: Would you take a look at this?

[jamesr, 2014-09-25 06:52:16]

lgtm

https://codereview.chromium.org/598903002/diff/20001/Source/web/WebKit.cpp
File Source/web/WebKit.cpp (right):

https://codereview.chromium.org/598903002/diff/20001/Source/web/WebKit.cpp#ne...
Source/web/WebKit.cpp:184: ASSERT(s_endOfTaskRunner);
this ASSERT() isn't needed any more.  delete NULL works fine

https://codereview.chromium.org/598903002/diff/20001/Source/web/WebKit.cpp#ne...
Source/web/WebKit.cpp:188: //
Platform::current()->currentThread()->removeTaskObserver(s_endOfTaskRunner);
having commented out code is not useful - just delete it

[haraken, 2014-09-25 06:53:23]

Thanks for quick review!

https://codereview.chromium.org/598903002/diff/20001/Source/web/WebKit.cpp
File Source/web/WebKit.cpp (right):

https://codereview.chromium.org/598903002/diff/20001/Source/web/WebKit.cpp#ne...
Source/web/WebKit.cpp:184: ASSERT(s_endOfTaskRunner);
On 2014/09/25 06:52:16, jamesr wrote:
> this ASSERT() isn't needed any more.  delete NULL works fine

Done.

https://codereview.chromium.org/598903002/diff/20001/Source/web/WebKit.cpp#ne...
Source/web/WebKit.cpp:188: //
Platform::current()->currentThread()->removeTaskObserver(s_endOfTaskRunner);
On 2014/09/25 06:52:16, jamesr wrote:
> having commented out code is not useful - just delete it

Done.

[haraken, 2014-09-25 06:53:44]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-09-25 06:54:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/598903002/40001

[commit-bot: I haz the power, 2014-09-25 08:00:50]

Committed patchset #3 (id:40001) as 182655

[Mads Ager (chromium), 2014-09-25 11:38:38]

ager@chromium.org changed reviewers:
+ ager@chromium.org

[Mads Ager (chromium), 2014-09-25 11:38:39]

Sorry about the slow response Haraken. LGTM too. Thanks to both you and James
for making sure that we do not touch Blink objects after Blink::shutdown!