Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 59883003: Additional string for protections against forced extension installs (Closed)

Created:
7 years, 1 month ago by asargent_no_longer_on_chrome
Modified:
7 years, 1 month ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

Additional string for protections against forced extension installs This is for the case where the dialog might overflow and we have to say "... and N more ..." TBR=finnur BUG=315192 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233052

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
asargent_no_longer_on_chrome
7 years, 1 month ago (2013-11-05 19:24:05 UTC) #1
asargent_no_longer_on_chrome
7 years, 1 month ago (2013-11-05 19:24:21 UTC) #2
asargent_no_longer_on_chrome
Committed patchset #1 manually as r233052 (presubmit successful).
7 years, 1 month ago (2013-11-05 19:24:43 UTC) #3
Finnur
https://codereview.chromium.org/59883003/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/59883003/diff/1/chrome/app/generated_resources.grd#newcode5150 chrome/app/generated_resources.grd:5150: + </message> I don't have the design doc in ...
7 years, 1 month ago (2013-11-05 22:55:39 UTC) #4
asargent_no_longer_on_chrome
Oops! Cue the I18n : I have no idea what I'm doing dog meme image. ...
7 years, 1 month ago (2013-11-06 00:45:10 UTC) #5
Finnur
7 years, 1 month ago (2013-11-06 10:09:38 UTC) #6
Message was sent while issue was closed.
Not a biggie. This is workable.

LGTM

Powered by Google App Engine
This is Rietveld 408576698