Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 598663002: Revert of DevTools: Made id unique across different remote browsers (Closed)

Created:
6 years, 3 months ago by dewittj
Modified:
6 years, 3 months ago
Reviewers:
vkuzkokov, dgozman, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Made id unique across different remote browsers (patchset #2 id:20001 of https://codereview.chromium.org/560523004/) Reason for revert: Need to delete the contents of chrome_beta_pages; see memory leak at https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20(3)/builds/7887 Original issue's description: > DevTools: Made id unique across different remote browsers > > BUG=338303 > > Committed: https://crrev.com/7732fd3f76fc31a95f14199f898804e5d80e96e3 > Cr-Commit-Position: refs/heads/master@{#296188} TBR=dgozman@chromium.org,pfeldman@chromium.org,vkuzkokov@chromium.org NOTREECHECKS=true NOTRY=true BUG=338303 Committed: https://crrev.com/156c0428293ffd31af87b815ca72c3602afd75df Cr-Commit-Position: refs/heads/master@{#296235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/device/adb/mock_adb_server.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/inspect_ui_test.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dewittj
Created Revert of DevTools: Made id unique across different remote browsers
6 years, 3 months ago (2014-09-23 17:18:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598663002/1
6 years, 3 months ago (2014-09-23 17:59:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f1ea2cd8feff73656434821f6e6445aa30ca6847
6 years, 3 months ago (2014-09-23 21:02:24 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:03:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/156c0428293ffd31af87b815ca72c3602afd75df
Cr-Commit-Position: refs/heads/master@{#296235}

Powered by Google App Engine
This is Rietveld 408576698