chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc - Issue 598663002: Revert of DevTools: Made id unique across different remote browsers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 598663002: Revert of DevTools: Made id unique across different remote browsers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

index d1d33baf9272e0facb2c47ba1754f65346ba957d..b6e2ec09901de0838200a1144c521d2ac706b0ef 100644

--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

@@ -101,12 +101,11 @@

webview->CreatePages();

ASSERT_EQ(1U, chrome_pages.size());

- ASSERT_EQ(1U, chrome_beta_pages.size());

+ ASSERT_EQ(0U, chrome_beta_pages.size());

ASSERT_EQ(2U, webview_pages.size());

// Check that we have non-empty description for webview pages.

ASSERT_EQ(0U, chrome_pages[0]->GetTarget()->GetDescription().size());

- ASSERT_EQ(0U, chrome_beta_pages[0]->GetTarget()->GetDescription().size());

ASSERT_NE(0U, webview_pages[0]->GetTarget()->GetDescription().size());

ASSERT_NE(0U, webview_pages[1]->GetTarget()->GetDescription().size());

« no previous file with comments | « no previous file | chrome/browser/devtools/device/adb/mock_adb_server.cc » ('j') | no next file with comments »