Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h

Issue 598593007: Make EnhancedBookmarkBridge initialized with profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
diff --git a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
index eeffbc6671464e390e30c0167a5b42362ca034e9..4c352802ee521f14d14915adfe7fe180d3d3228f 100644
--- a/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
+++ b/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h
@@ -6,15 +6,15 @@
#define CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_
#include "base/android/jni_android.h"
-
-class BookmarkModel;
+#include "chrome/browser/profiles/profile.h"
+#include "components/bookmarks/browser/bookmark_model.h"
Kibeom Kim (inactive) 2014/09/29 18:41:25 nit: keep forward-declaration instead of includes?
namespace enhanced_bookmarks {
namespace android {
class EnhancedBookmarksBridge {
public:
- EnhancedBookmarksBridge(JNIEnv* env, jobject obj, jlong bookmark_model_ptr);
+ EnhancedBookmarksBridge(JNIEnv* env, jobject obj, Profile* profile);
void Destroy(JNIEnv*, jobject);
base::android::ScopedJavaLocalRef<jstring> GetBookmarkDescription(
@@ -31,7 +31,7 @@ class EnhancedBookmarksBridge {
private:
BookmarkModel* bookmark_model_; // weak
-
+ Profile* profile_; // weak
Yaron 2014/09/29 18:14:58 Do you have an intended use for this? If not, I'd
DISALLOW_COPY_AND_ASSIGN(EnhancedBookmarksBridge);
};

Powered by Google App Engine
This is Rietveld 408576698