Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h

Issue 598593007: Make EnhancedBookmarkBridge initialized with profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_ 6 #define CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H_
7 7
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 9 #include "chrome/browser/profiles/profile.h"
10 class BookmarkModel; 10 #include "components/bookmarks/browser/bookmark_model.h"
Kibeom Kim (inactive) 2014/09/29 18:41:25 nit: keep forward-declaration instead of includes?
11 11
12 namespace enhanced_bookmarks { 12 namespace enhanced_bookmarks {
13 namespace android { 13 namespace android {
14 14
15 class EnhancedBookmarksBridge { 15 class EnhancedBookmarksBridge {
16 public: 16 public:
17 EnhancedBookmarksBridge(JNIEnv* env, jobject obj, jlong bookmark_model_ptr); 17 EnhancedBookmarksBridge(JNIEnv* env, jobject obj, Profile* profile);
18 void Destroy(JNIEnv*, jobject); 18 void Destroy(JNIEnv*, jobject);
19 19
20 base::android::ScopedJavaLocalRef<jstring> GetBookmarkDescription( 20 base::android::ScopedJavaLocalRef<jstring> GetBookmarkDescription(
21 JNIEnv* env, 21 JNIEnv* env,
22 jobject obj, 22 jobject obj,
23 jlong id, 23 jlong id,
24 jint type); 24 jint type);
25 25
26 void SetBookmarkDescription(JNIEnv* env, 26 void SetBookmarkDescription(JNIEnv* env,
27 jobject obj, 27 jobject obj,
28 jlong id, 28 jlong id,
29 jint type, 29 jint type,
30 jstring description); 30 jstring description);
31 31
32 private: 32 private:
33 BookmarkModel* bookmark_model_; // weak 33 BookmarkModel* bookmark_model_; // weak
34 34 Profile* profile_; // weak
Yaron 2014/09/29 18:14:58 Do you have an intended use for this? If not, I'd
35 DISALLOW_COPY_AND_ASSIGN(EnhancedBookmarksBridge); 35 DISALLOW_COPY_AND_ASSIGN(EnhancedBookmarksBridge);
36 }; 36 };
37 37
38 bool RegisterEnhancedBookmarksBridge(JNIEnv* env); 38 bool RegisterEnhancedBookmarksBridge(JNIEnv* env);
39 39
40 } // namespace android 40 } // namespace android
41 } // namespace enhanced_bookmarks 41 } // namespace enhanced_bookmarks
42 42
43 #endif // CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H _ 43 #endif // CHROME_BROWSER_ANDROID_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARKS_BRIDGE_H _
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698