Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 598593007: Make EnhancedBookmarkBridge initialized with profile (Closed)

Created:
6 years, 2 months ago by Ian Wen
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make EnhancedBookmarkBridge initialized with profile EnhancedBookmarkBridge was previously initialized by a native pointer of the native BookmarkModel, which was a hack to make it to component folder. Now since it has been moved to chrome/browser, it should be initialized by profile. BUG=415817 Committed: https://crrev.com/7352c3034231d9743158dac1ea9c839aada226c5 Cr-Commit-Position: refs/heads/master@{#297265}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -28 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h View 2 chunks +4 lines, -4 lines 2 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ian Wen
6 years, 2 months ago (2014-09-29 18:10:42 UTC) #2
Yaron
lgtm https://codereview.chromium.org/598593007/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h (right): https://codereview.chromium.org/598593007/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h#newcode34 chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:34: Profile* profile_; // weak Do you have an ...
6 years, 2 months ago (2014-09-29 18:14:59 UTC) #3
Kibeom Kim (inactive)
lgtm https://codereview.chromium.org/598593007/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h (right): https://codereview.chromium.org/598593007/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h#newcode10 chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:10: #include "components/bookmarks/browser/bookmark_model.h" nit: keep forward-declaration instead of includes?
6 years, 2 months ago (2014-09-29 18:41:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598593007/1
6 years, 2 months ago (2014-09-29 20:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1625e6c351e6d4f57d429ffbfb760f3f1f65a6e1
6 years, 2 months ago (2014-09-29 21:14:45 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:15:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7352c3034231d9743158dac1ea9c839aada226c5
Cr-Commit-Position: refs/heads/master@{#297265}

Powered by Google App Engine
This is Rietveld 408576698