IDL compiler: [PerContextEnabled] methods

IDL compiler: [PerContextEnabled] methods

BUG=239771
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161509

[Nils Barth (inactive), 2013-11-07 04:49:35]

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:103: {% if constants or
has_runtime_enabled_attributes or
This check is complicated and looks unnecessary;
can we always include this code?
(If it's ok, I'll remove trying removing this test from Perl and Python in a
followup CL.)

The Perl condition (l. 4431) is:
$accessCheck or @runtimeEnabledAttributes or @normalFunctions or $hasConstants
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

...which basically means:
"unless you're all attributes, include these lines"
...so it's almost always true.

[haraken, 2013-11-07 04:55:09]

LGTM

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:103: {% if constants or
has_runtime_enabled_attributes or
On 2013/11/07 04:49:35, Nils Barth wrote:
> This check is complicated and looks unnecessary;
> can we always include this code?
> (If it's ok, I'll remove trying removing this test from Perl and Python in a
> followup CL.)
> 
> The Perl condition (l. 4431) is:
> $accessCheck or @runtimeEnabledAttributes or @normalFunctions or $hasConstants
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> ...which basically means:
> "unless you're all attributes, include these lines"
> ...so it's almost always true.

Yes, I think you can always include the code. Having both
|per_context_enabled_methods| and |non_per_context_enabled_methods| is weird.
Let's remove |non_per_context_enabled_methods|.

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:233: void
{{v8_class_name}}::installPerContextEnabledPrototypeProperties(v8::Handle<v8::Object>
proto, v8::Isolate* isolate)

installPerContextEnabledPrototypeProperties => installPerContextEnabledMethods

proto => prototype

[Nils Barth (inactive), 2013-11-07 05:07:01]

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:103: {% if constants or
has_runtime_enabled_attributes or
On 2013/11/07 04:55:09, haraken wrote:
> Yes, I think you can always include the code. Having both
> |per_context_enabled_methods| and |non_per_context_enabled_methods| is weird.
> Let's remove |non_per_context_enabled_methods|.

Agreed, it's pretty disgusting;
will do in followup once this lands.

https://codereview.chromium.org/59853010/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:233: void
{{v8_class_name}}::installPerContextEnabledPrototypeProperties(v8::Handle<v8::Object>
proto, v8::Isolate* isolate)
On 2013/11/07 04:55:09, haraken wrote:
> installPerContextEnabledPrototypeProperties => installPerContextEnabledMethods
> 
> proto => prototype

Got it, will do in followup.

[commit-bot: I haz the power, 2013-11-07 07:46:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/59853010/70001

[commit-bot: I haz the power, 2013-11-07 07:46:48]

Change committed as 161509