IDL compiler: [PerContextEnabled] methods

Source/bindings/templates/interface.cpp

 {% extends 'interface_base.cpp' %}
 
 
 {##############################################################################}
 {% macro attribute_configuration(attribute) %}
 {"{{attribute.name}}", {{attribute.getter_callback_name}}, {{attribute.setter_callback_name}}, {{attribute.getter_callback_name_for_main_world}}, {{attribute.setter_callback_name_for_main_world}}, {{attribute.wrapper_type_info}}, static_cast<v8::AccessControl>({{attribute.access_control_list | join(' | ')}}), static_cast<v8::PropertyAttribute>({{attribute.property_attributes | join(' | ')}}), 0 /* on instance */}
 {%- endmacro %}
 
 
 {##############################################################################}
@@ skipping 55 matching lines @@
 
 {% endif %}
 {% endblock %}
 
 
 {##############################################################################}
 {% block class_methods %}
 {# FIXME: rename to install_methods and put into configure_class_template #}
 {% if methods %}
 static const V8DOMConfiguration::MethodConfiguration {{v8_class_name}}Methods[] = {
-    {% for method in methods if method.do_not_check_signature %}
+    {% for method in methods
+       if method.do_not_check_signature and
+          not method.per_context_enabled_function_name %}
     {% filter conditional(method.conditional_string) %}
     {{method_configuration(method)}},
     {% endfilter %}
     {% endfor %}
 };
 
 {% endif %}
 {% endblock %}
 
 
 {##############################################################################}
 {% block configure_class_template %}
 {# FIXME: rename to install_dom_template and Install{{v8_class_name}}DOMTemplate #}
 static v8::Handle<v8::FunctionTemplate> Configure{{v8_class_name}}Template(v8::Handle<v8::FunctionTemplate> desc, v8::Isolate* isolate, WrapperWorldType currentWorldType)
 {
     desc->ReadOnlyPrototype();
 
     v8::Local<v8::Signature> defaultSignature;
     defaultSignature = V8DOMConfiguration::installDOMClassTemplate(desc, "{{interface_name}}", v8::Local<v8::FunctionTemplate>(), {{v8_class_name}}::internalFieldCount,
         {# Test needed as size 0 constant arrays are not allowed in VC++ #}
         {%+ if attributes %}{{v8_class_name}}Attributes, WTF_ARRAY_LENGTH({{v8_class_name}}Attributes){% else %}0, 0{% endif %},
         {%+ if methods %}{{v8_class_name}}Methods, WTF_ARRAY_LENGTH({{v8_class_name}}Methods){% else %}0, 0{% endif %},
         isolate, currentWorldType);
     UNUSED_PARAM(defaultSignature);
-    {% if constants or has_runtime_enabled_attributes %}
+    {% if constants or has_runtime_enabled_attributes or

[Nils Barth (inactive), 2013/11/07 04:49:35]

This check is complicated and looks unnecessary;
can we always include this code?
(If it's ok, I'll remove trying removing this test from Perl and Python in a
followup CL.)

The Perl condition (l. 4431) is:
$accessCheck or @runtimeEnabledAttributes or @normalFunctions or $hasConstants
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

...which basically means:
"unless you're all attributes, include these lines"
...so it's almost always true.

[haraken, 2013/11/07 04:55:09]

Yes, I think you can always include the code. Having both
|per_context_enabled_methods| and |non_per_context_enabled_methods| is weird.
Let's remove |non_per_context_enabled_methods|.

[Nils Barth (inactive), 2013/11/07 05:07:02]

Agreed, it's pretty disgusting;
will do in followup once this lands.

+          has_non_per_context_enabled_methods %}
     v8::Local<v8::ObjectTemplate> instance = desc->InstanceTemplate();
     v8::Local<v8::ObjectTemplate> proto = desc->PrototypeTemplate();
     UNUSED_PARAM(instance);
     UNUSED_PARAM(proto);
     {% endif %}
     {% for attribute in attributes if attribute.runtime_enabled_function_name %}
     {% filter conditional(attribute.conditional_string) %}
     if ({{attribute.runtime_enabled_function_name}}()) {
         static const V8DOMConfiguration::AttributeConfiguration attributeConfiguration =\
         {{attribute_configuration(attribute)}};
@@ skipping 106 matching lines @@
         V8DOMConfiguration::installAttribute(instance, proto, attributeConfiguration, isolate);
     }
     {% endfor %}
 }
 
 {% endif %}
 {% endblock %}
 
 
 {##############################################################################}
+{% block install_per_context_methods %}
+{% if has_per_context_enabled_methods %}
+void {{v8_class_name}}::installPerContextEnabledPrototypeProperties(v8::Handle<v8::Object> proto, v8::Isolate* isolate)

[haraken, 2013/11/07 04:55:09]

installPerContextEnabledPrototypeProperties => installPerContextEnabledMethods

proto => prototype

[Nils Barth (inactive), 2013/11/07 05:07:02]

Got it, will do in followup.

+{
+    UNUSED_PARAM(proto);
+    {# Define per-context enabled operations #}
+    v8::Local<v8::Signature> defaultSignature = v8::Signature::New(GetTemplate(isolate, worldType(isolate)));
+    UNUSED_PARAM(defaultSignature);
+
+    ExecutionContext* context = toExecutionContext(proto->CreationContext());
+    {% for method in methods if method.per_context_enabled_function_name %}
+    if (context && context->isDocument() && {{method.per_context_enabled_function_name}}(toDocument(context)))
+        proto->Set(v8::String::NewSymbol("{{method.name}}"), v8::FunctionTemplate::New({{cpp_class_name}}V8Internal::{{method.name}}MethodCallback, v8Undefined(), defaultSignature, {{method.number_of_required_arguments}})->GetFunction());
+    {% endfor %}
+}
+
+{% endif %}
+{% endblock %}
+
+
+{##############################################################################}
 {% block create_wrapper_and_deref_object %}
 v8::Handle<v8::Object> {{v8_class_name}}::createWrapper(PassRefPtr<{{cpp_class_name}}> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT(impl);
     ASSERT(!DOMDataStore::containsWrapper<{{v8_class_name}}>(impl.get(), isolate));
     if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {
         const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObject(impl.get());
         // Might be a XXXConstructor::wrapperTypeInfo instead of an XXX::wrapperTypeInfo. These will both have
         // the same object de-ref functions, though, so use that as the basis of the check.
         RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == wrapperTypeInfo.derefObjectFunction);
     }
 
     v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext, &wrapperTypeInfo, toInternalPointer(impl.get()), isolate);
     if (UNLIKELY(wrapper.IsEmpty()))
         return wrapper;
 
     installPerContextEnabledProperties(wrapper, impl.get(), isolate);
     V8DOMWrapper::associateObjectWithWrapper<{{v8_class_name}}>(impl, &wrapperTypeInfo, wrapper, isolate, WrapperConfiguration::Independent);
     return wrapper;
 }
 
 void {{v8_class_name}}::derefObject(void* object)
 {
     fromInternalPointer(object)->deref();
 }
 
 {% endblock %}