Issue 598503003: Revert of Remove default args to several PageWidgetDelegate members, try 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 598503003: Revert of Remove default args to several PageWidgetDelegate members, try 2. (Closed)

Created:
6 years, 2 months ago by dcheng

Modified:
6 years, 2 months ago

Reviewers:
kenrb, Nate Chapin

CC:
blink-reviews, mkwst+moarreviews_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revert of Remove default args to several PageWidgetDelegate members, try 2. (patchset #2 id:20001 of https://codereview.chromium.org/604463004/) Reason for revert: Causing crashes on canary. Original issue's description: > Remove default args to several PageWidgetDelegate members, try 2. > > BUG=411993 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182737 TBR=japhet@chromium.org,kenrb@chromium.org NOTREECHECKS=true NOTRY=true BUG=411993 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182873

Created: 6 years, 2 months ago

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -43 lines)
M	Source/web/PageWidgetDelegate.h	View	1 chunk	+4 lines, -4 lines	0 comments
M	Source/web/PageWidgetDelegate.cpp	View	4 chunks	+47 lines, -29 lines	0 comments
M	Source/web/WebPagePopupImpl.cpp	View	3 chunks	+4 lines, -4 lines	0 comments
M	Source/web/WebViewImpl.cpp	View	4 chunks	+4 lines, -6 lines	0 comments

Total messages: 3 (0 generated)

dcheng

Created Revert of Remove default args to several PageWidgetDelegate members, try 2.

6 years, 2 months ago (2014-09-30 00:04:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598503003/1

6 years, 2 months ago (2014-09-30 00:04:45 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-09-30 00:05:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182873