content/renderer/pepper/pepper_plugin_instance_impl.h - Issue 598483002: Fix WeakPtrFactory member ordering in content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated changes as per comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.h

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.h b/content/renderer/pepper/pepper_plugin_instance_impl.h

index 2c7884e7d19ded4b7e2fed60be4f63fbb65532ec..629372e7d55b9f3d43accb0d30d6c7fdcad8d9bc 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.h

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.h

@@ -552,6 +552,7 @@ class CONTENT_EXPORT PepperPluginInstanceImpl

private:

friend class base::RefCounted<PepperPluginInstanceImpl>;

friend class PpapiUnittest;

+ friend class PpapiPluginInstanceTest;

Avi (use Gerrit) 2014/09/25 04:08:26 Prefer alphabetical order; can you switch the two

MRV 2014/09/25 04:37:17 Done.

// Delete should be called by the WebPlugin before this destructor.

virtual ~PepperPluginInstanceImpl();

@@ -923,7 +924,6 @@ class CONTENT_EXPORT PepperPluginInstanceImpl

base::WeakPtrFactory<PepperPluginInstanceImpl> view_change_weak_ptr_factory_;

base::WeakPtrFactory<PepperPluginInstanceImpl> weak_factory_;

- friend class PpapiPluginInstanceTest;

DISALLOW_COPY_AND_ASSIGN(PepperPluginInstanceImpl);

};

« no previous file with comments | « content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('k') | no next file » | no next file with comments »