Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: content/renderer/accessibility/renderer_accessibility_complete.h

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated changes as per comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/renderer_accessibility_complete.h
diff --git a/content/renderer/accessibility/renderer_accessibility_complete.h b/content/renderer/accessibility/renderer_accessibility_complete.h
index cb34c15642910873d164b787d8fce5bfb497d6ae..63c0d7e690b89ccb072cdc7b2bd35e828b4e8516 100644
--- a/content/renderer/accessibility/renderer_accessibility_complete.h
+++ b/content/renderer/accessibility/renderer_accessibility_complete.h
@@ -72,9 +72,6 @@ class CONTENT_EXPORT RendererAccessibilityComplete
void OnHitTest(gfx::Point point);
void OnFatalError();
- // So we can queue up tasks to be executed later.
- base::WeakPtrFactory<RendererAccessibilityComplete> weak_factory_;
-
// Events from Blink are collected until they are ready to be
// sent to the browser.
std::vector<AccessibilityHostMsg_EventParams> pending_events_;
@@ -96,6 +93,9 @@ class CONTENT_EXPORT RendererAccessibilityComplete
// Set if we are waiting for an accessibility event ack.
bool ack_pending_;
+ // So we can queue up tasks to be executed later.
+ base::WeakPtrFactory<RendererAccessibilityComplete> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(RendererAccessibilityComplete);
};

Powered by Google App Engine
This is Rietveld 408576698