Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/BUILD.gn

Issue 598353003: Handle the "debug_devtools" build arg in GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make use of the "debug_devtools" config added on the Blink side Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 8181e41c37ef4f86bd5da4905789310b9cc538ab..da9e63df8986146535ba3347af8e70fc67a442b5 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -25,7 +25,10 @@ gypi_values = exec_script(
[ "../chrome_browser.gypi" ])
static_library("browser") {
- configs += [ "//build/config/compiler:wexit_time_destructors" ]
+ configs += [
+ "//build/config/compiler:wexit_time_destructors",
+ "//third_party/WebKit/public:debug_devtools",
+ ]
defines = []
sources = []
libs = []
@@ -273,10 +276,7 @@ static_library("browser") {
".", "//chrome")
#deps += [ "//components/nacl:nacl_browser" ] TODO(GYP)
}
- # ["debug_devtools==1", { TODO(GYP)
- # "defines": [
- # "DEBUG_DEVTOOLS=1",
- # }],
+
if (enable_configuration_policy) {
sources += rebase_path(
gypi_values.chrome_browser_policy_shared_with_ios_sources,
« no previous file with comments | « no previous file | chrome/browser/devtools/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698