chrome/browser/devtools/BUILD.gn - Issue 598353003: Handle the "debug_devtools" build arg in GN builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/BUILD.gn

Issue 598353003: Handle the "debug_devtools" build arg in GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make use of the "debug_devtools" config added on the Blink side Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/BUILD.gn

diff --git a/chrome/browser/devtools/BUILD.gn b/chrome/browser/devtools/BUILD.gn

index 9404d4bdf6248eeb328a871c634bfbcf3d7905f4..0d2d4ab1f4d855aea5dfa32b038352e347c44df0 100644

--- a/chrome/browser/devtools/BUILD.gn

+++ b/chrome/browser/devtools/BUILD.gn

@@ -40,17 +40,14 @@ static_library("devtools") {

]

sources += get_target_outputs(":devtools_protocol_constants")

- # TODO(GYP)

- # ['debug_devtools==1', {

- # 'defines': [

- # 'DEBUG_DEVTOOLS=1',

- # ],

- # }],

if (is_win) {

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

cflags = [ "/wd4267" ]

}

- configs += [ "//build/config/compiler:wexit_time_destructors" ]

+ configs += [

+ "//build/config/compiler:wexit_time_destructors",

+ "//third_party/WebKit/public:debug_devtools",

+ ]

deps = [

":devtools_protocol_constants",

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »