Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/BUILD.gn

Issue 598353003: Handle the "debug_devtools" build arg in GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/BUILD.gn » ('j') | chrome/browser/devtools/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 8181e41c37ef4f86bd5da4905789310b9cc538ab..5df54bef6b18c2396d1d57b72b59ac768d07f0b4 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -148,6 +148,10 @@ static_library("browser") {
defines = nacl_defines
+ if (debug_devtools) {
+ defines += [ "DEBUG_DEVTOOLS=1" ]
+ }
+
deps += [
"//apps",
"//cc",
@@ -273,10 +277,7 @@ static_library("browser") {
".", "//chrome")
#deps += [ "//components/nacl:nacl_browser" ] TODO(GYP)
}
- # ["debug_devtools==1", { TODO(GYP)
- # "defines": [
- # "DEBUG_DEVTOOLS=1",
- # }],
+
if (enable_configuration_policy) {
sources += rebase_path(
gypi_values.chrome_browser_policy_shared_with_ios_sources,
« no previous file with comments | « no previous file | chrome/browser/devtools/BUILD.gn » ('j') | chrome/browser/devtools/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698