Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4404)

Unified Diff: chrome/browser/devtools/BUILD.gn

Issue 598353003: Handle the "debug_devtools" build arg in GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/BUILD.gn
diff --git a/chrome/browser/devtools/BUILD.gn b/chrome/browser/devtools/BUILD.gn
index 9404d4bdf6248eeb328a871c634bfbcf3d7905f4..9bf5a253507cb1a0a3c1e3c9af66768efedda5a4 100644
--- a/chrome/browser/devtools/BUILD.gn
+++ b/chrome/browser/devtools/BUILD.gn
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/features.gni")
+
action("devtools_protocol_constants") {
script = "//content/public/browser/devtools_protocol_constants_generator.py"
@@ -21,6 +23,8 @@ action("devtools_protocol_constants") {
# GYP version: chrome/chrome_debugger.gypi:debugger
static_library("devtools") {
+ defines = []
+
# Note: new sources and deps should be generally added in (!is_android) below.
sources = [
"devtools_network_conditions.cc",
@@ -40,12 +44,10 @@ static_library("devtools") {
]
sources += get_target_outputs(":devtools_protocol_constants")
- # TODO(GYP)
- # ['debug_devtools==1', {
- # 'defines': [
- # 'DEBUG_DEVTOOLS=1',
- # ],
- # }],
+ if (debug_devtools) {
+ defines += [ "DEBUG_DEVTOOLS=1" ]
brettw 2014/09/25 20:40:53 It would be nice to have a config somewhere that d
apavlov 2014/09/26 07:10:27 Good point. I've got https://codereview.chromium.o
+ }
+
if (is_win) {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
cflags = [ "/wd4267" ]
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698