Handle the "debug_devtools" build arg in GN builds

Handle the "debug_devtools" build arg in GN builds

R=brettw,pfeldman

Committed: https://crrev.com/e749bca93085d521049eb285337dd09fe3d38002
Cr-Commit-Position: refs/heads/master@{#297401}

[apavlov, 2014-09-25 14:47:51]

apavlov@chromium.org changed reviewers:
+ jochen@chromium.org

[apavlov, 2014-09-25 14:47:51]

+@jochen as an OWNER

[brettw, 2014-09-25 20:40:53]

https://codereview.chromium.org/598353003/diff/1/chrome/browser/devtools/BUIL...
File chrome/browser/devtools/BUILD.gn (right):

https://codereview.chromium.org/598353003/diff/1/chrome/browser/devtools/BUIL...
chrome/browser/devtools/BUILD.gn:48: defines += [ "DEBUG_DEVTOOLS=1" ]
It would be nice to have a config somewhere that defines this so we don't need
to hardcode the name in several places. I notice there is an existing one in
chrome/browser/ui/BUILD.gn

It looks like WebKit also needs to be checked (not sure if you already did this
or knew about it). I see at least one "debug_devtools = false" in a file there
with a TODO.

Can we have a config in blink (since it defines what devtools are) that does
this, and then set that config on targets that need this value?

configs += [ "//third_party/WebKit/public:debug_devtools" ]
or something.

[apavlov, 2014-09-26 07:10:27]

https://codereview.chromium.org/598353003/diff/1/chrome/browser/devtools/BUIL...
File chrome/browser/devtools/BUILD.gn (right):

https://codereview.chromium.org/598353003/diff/1/chrome/browser/devtools/BUIL...
chrome/browser/devtools/BUILD.gn:48: defines += [ "DEBUG_DEVTOOLS=1" ]
On 2014/09/25 20:40:53, brettw wrote:
> It would be nice to have a config somewhere that defines this so we don't need
> to hardcode the name in several places. I notice there is an existing one in
> chrome/browser/ui/BUILD.gn
> 
> It looks like WebKit also needs to be checked (not sure if you already did
this
> or knew about it). I see at least one "debug_devtools = false" in a file there
> with a TODO.
> 
> Can we have a config in blink (since it defines what devtools are) that does
> this, and then set that config on targets that need this value?
> 
> configs += [ "//third_party/WebKit/public:debug_devtools" ]
> or something.

Good point. I've got https://codereview.chromium.org/608523002/ where I fix the
Blink part. I've added you to the R list and created the "debug_devtools" config
as you suggest. Please take a look, as that should be landed first.

[brettw, 2014-09-26 18:25:48]

LGTM

[jochen (gone - plz use gerrit), 2014-09-30 08:07:45]

lgtm

[apavlov, 2014-09-30 09:10:34]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-09-30 09:11:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/598353003/20001

[commit-bot: I haz the power, 2014-09-30 09:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 09:19:53]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[apavlov, 2014-09-30 10:53:15]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-09-30 10:54:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/598353003/20001

[commit-bot: I haz the power, 2014-09-30 11:07:47]

Committed patchset #2 (id:20001) as 1973166c2f7a0fa6b89374c071e087d25e299f45

[commit-bot: I haz the power, 2014-09-30 11:08:25]

Patchset 2 (id:??) landed as
https://crrev.com/e749bca93085d521049eb285337dd09fe3d38002
Cr-Commit-Position: refs/heads/master@{#297401}