Chromecast: adds CastNetworkDelegate.

chromecast/shell/browser/cast_browser_main_parts.cc

Index: chromecast/shell/browser/cast_browser_main_parts.cc
diff --git a/chromecast/shell/browser/cast_browser_main_parts.cc b/chromecast/shell/browser/cast_browser_main_parts.cc
index 084cc273f4c52cc45c61fc0592ab9e67da0e5c25..0dbcce602823663a288000e48913fda6d9dbfd28 100644
--- a/chromecast/shell/browser/cast_browser_main_parts.cc
+++ b/chromecast/shell/browser/cast_browser_main_parts.cc
@@ -104,6 +104,9 @@ void CastBrowserMainParts::PreMainMessageLoopRun() {
   cast_browser_process_->SetCastService(
       CastService::Create(cast_browser_process_->browser_context(),
                           url_request_context_factory_->GetSystemGetter()));

[lcwu1, 2014/09/26 22:38:59]

Now that I looked at the internal CLs, I think I am fine with your network
delegate class structure. My original comment of not passing in a network
delegate object in CastService's Create function is based on the assumption that
CastNetworkDelegate is not referenced in Chromecast code directly. (That is, it
is only used by higher-level content or net code.) But now that we make it also
do DeviceIdSettings stuff, it makes sense to pass in the network delegate. (And
in fact, we have to pass it in anyway because we don't expose url request
context factory in cast service.)

[gunsch, 2014/09/26 23:03:05]

Done.

+
+  // Initializing network delegates must happen after Cast service is created.
+  url_request_context_factory_->InitializeNetworkDelegates();
   cast_browser_process_->cast_service()->Start();
 }