Chromecast: adds CastNetworkDelegate.

chromecast/shell/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/shell/browser/cast_browser_main_parts.h"
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "chromecast/common/chromecast_config.h"
@@ skipping 85 matching lines @@
       metrics::CastMetricsServiceClient::Create(
           content::BrowserThread::GetBlockingPool(),
           ChromecastConfig::GetInstance()->pref_service(),
           cast_browser_process_->browser_context()->GetRequestContext()));
   cast_browser_process_->SetRemoteDebuggingServer(new RemoteDebuggingServer());
 
   InitializeWebUI();
 
   cast_browser_process_->SetCastService(
       CastService::Create(cast_browser_process_->browser_context(),
                           url_request_context_factory_->GetSystemGetter()));

[lcwu1, 2014/09/26 22:38:59]

Now that I looked at the internal CLs, I think I am fine with your network
delegate class structure. My original comment of not passing in a network
delegate object in CastService's Create function is based on the assumption that
CastNetworkDelegate is not referenced in Chromecast code directly. (That is, it
is only used by higher-level content or net code.) But now that we make it also
do DeviceIdSettings stuff, it makes sense to pass in the network delegate. (And
in fact, we have to pass it in anyway because we don't expose url request
context factory in cast service.)

[gunsch, 2014/09/26 23:03:05]

Done.

+
+  // Initializing network delegates must happen after Cast service is created.
+  url_request_context_factory_->InitializeNetworkDelegates();
   cast_browser_process_->cast_service()->Start();
 }
 
 bool CastBrowserMainParts::MainMessageLoopRun(int* result_code) {
   // If parameters_.ui_task is not NULL, we are running browser tests. In this
   // case, the browser's main message loop will not run.
   if (parameters_.ui_task) {
     parameters_.ui_task->Run();
   } else {
     base::MessageLoopForUI::current()->Run();
   }
   return true;
 }
 
 void CastBrowserMainParts::PostMainMessageLoopRun() {
   cast_browser_process_->cast_service()->Stop();
   cast_browser_process_.reset();
 }
 
 }  // namespace shell
 }  // namespace chromecast