Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

Issue 598163002: [Win] Redesign the new avatar button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move static var declaration Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
index 6366fadc3f7f03d15c2c02ce66a428d145ec1252..a7dd9d984a12cb0a1e88fdafc168c7461712a540 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
@@ -8,6 +8,7 @@
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/ui/views/profiles/avatar_label.h"
#include "chrome/browser/ui/views/profiles/avatar_menu_button.h"
+#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/common/chrome_switches.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "ui/gfx/font.h"
@@ -382,21 +383,26 @@ void OpaqueBrowserFrameViewLayout::LayoutNewStyleAvatar(views::View* host) {
if (!new_avatar_button_)
return;
- gfx::Size label_size = new_avatar_button_->GetPreferredSize();
- int button_size_with_offset = kNewAvatarButtonOffset + label_size.width();
+ int button_width = new_avatar_button_->GetPreferredSize().width();
+ int button_width_with_offset = button_width + kNewAvatarButtonOffset;
- int button_x = host->width() - trailing_button_start_ -
- button_size_with_offset;
+ int button_x =
+ host->width() - trailing_button_start_ - button_width_with_offset;
int button_y = CaptionButtonY(!IsTitleBarCondensed());
- trailing_button_start_ += button_size_with_offset;
- minimum_size_for_buttons_ += button_size_with_offset;
+ minimum_size_for_buttons_ += button_width_with_offset;
+ trailing_button_start_ += button_width_with_offset;
+
+ // In non-maximized mode, allow the new tab button to completely slide under
+ // the avatar button.
+ if (!IsTitleBarCondensed()) {
+ trailing_button_start_ -=
+ TabStrip::kNewTabButtonAssetWidth + kNewTabCaptionNormalSpacing;
+ }
// Do not include the 1px padding that is added for the caption buttons.
- new_avatar_button_->SetBounds(button_x,
- button_y,
- label_size.width(),
- kCaptionButtonHeightWithPadding - 1);
+ new_avatar_button_->SetBounds(
+ button_x, button_y, button_width, kCaptionButtonHeightWithPadding - 1);
}
void OpaqueBrowserFrameViewLayout::LayoutAvatar(views::View* host) {

Powered by Google App Engine
This is Rietveld 408576698