Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Issue 598163002: [Win] Redesign the new avatar button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move static var declaration Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/glass_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
index 116a7b9d9615873522555058e4b0375d03c8cfb6..3e59d005b02916fe089b3fe23a5e7099e52e3858 100644
--- a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
@@ -112,7 +112,15 @@ gfx::Rect GlassBrowserFrameView::GetBoundsForTabStrip(
// minimize button.
if (new_avatar_button()) {
DCHECK(switches::IsNewAvatarMenu());
- minimize_button_offset -= new_avatar_button()->width();
+ minimize_button_offset -=
+ new_avatar_button()->width() + kNewAvatarButtonOffset;
+
+ // In non-maximized mode, allow the new tab button to completely slide under
+ // the avatar button.
+ if (!frame()->IsMaximized() && !base::i18n::IsRTL()) {
+ minimize_button_offset +=
+ TabStrip::kNewTabButtonAssetWidth + kNewTabCaptionRestoredSpacing;
+ }
}
int tabstrip_x = browser_view()->ShouldShowAvatar() ?

Powered by Google App Engine
This is Rietveld 408576698