Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 598023002: Add indentation offset guess for gyp emacs mode. (Closed)

Created:
6 years, 3 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 1 month ago
Reviewers:
Nico, gavinp
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Add indentation offset guess for gyp emacs mode. This fixes the indentation for some of the gyp files using 4 spaces indentation instead of the usual 2. Also adds "ldflags" in the list of keywords.

Patch Set 1 #

Total comments: 30

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M tools/emacs/gyp.el View 1 3 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Fabrice (no longer in Chrome)
+gavinp for code review and comments. +thakis to actually land it after.
6 years, 3 months ago (2014-09-24 14:27:08 UTC) #2
gavinp
Thanks for making this better! Google does not have a public Emacs Lisp coding standard. ...
6 years, 2 months ago (2014-09-25 20:07:34 UTC) #3
Fabrice (no longer in Chrome)
Thanks a lot Gavin! I modified the file with your comments, but kept the continuation ...
6 years, 2 months ago (2014-09-26 12:23:37 UTC) #4
gavinp
lgtm, thanks!
6 years, 1 month ago (2014-10-27 16:09:31 UTC) #5
Fabrice (no longer in Chrome)
Thanks Gavin! Nico, can you land it?
6 years, 1 month ago (2014-10-28 10:39:09 UTC) #6
Nico
Sure, can do, but shouldn't all gyp files just use 2 indent? Which ones don't?
6 years, 1 month ago (2014-10-28 16:34:54 UTC) #7
Nico
Landed in gyp r1995
6 years, 1 month ago (2014-10-28 16:35:48 UTC) #8
Fabrice (no longer in Chrome)
On 2014/10/28 16:34:54, Nico wrote: > Sure, can do, but shouldn't all gyp files just ...
6 years, 1 month ago (2014-10-28 16:36:50 UTC) #9
Fabrice (no longer in Chrome)
6 years, 1 month ago (2014-10-28 17:57:27 UTC) #10
And thanks for landing it!
Closing this.

Powered by Google App Engine
This is Rietveld 408576698