Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 597943003: Move i18n-related runtime functions into a separate file. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move i18n-related runtime functions into a separate file. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24202

Patch Set 1 #

Patch Set 2 : adapt check-name-clashes.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2234 lines, -19240 lines) Patch
M BUILD.gn View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/builtins-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D src/runtime.h View 1 1 chunk +0 lines, -922 lines 0 comments Download
D src/runtime.cc View 1 1 chunk +0 lines, -15758 lines 0 comments Download
A + src/runtime/runtime.h View 1 13 chunks +392 lines, -407 lines 0 comments Download
A + src/runtime/runtime.cc View 1 313 chunks +904 lines, -2116 lines 0 comments Download
A src/runtime/runtime-i18n.cc View 1 1 chunk +751 lines, -0 lines 0 comments Download
A src/runtime/runtime-utils.h View 1 1 chunk +146 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/check-name-clashes.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tools/lexer-shell.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 3 months ago (2014-09-24 11:33:09 UTC) #1
Yang
On 2014/09/24 11:33:09, Yang wrote: Eventually we want to move all implementations out of runtime.cc ...
6 years, 3 months ago (2014-09-24 11:34:36 UTC) #2
Benedikt Meurer
LGTM (rubber-stamped)
6 years, 3 months ago (2014-09-24 11:36:24 UTC) #3
Yang
6 years, 2 months ago (2014-09-25 07:17:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as 24202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698