Restored disable print preview policy.

Restored disable print preview policy.
Not exact revert of https://codereview.chromium.org/488853002

BUG=374321, 416396
Committed: https://crrev.com/15daa893f50daebf33ccf06ba67d74788700e495
Cr-Commit-Position: refs/heads/master@{#296751}

Committed: https://crrev.com/a7ae5053246257da01d01120bf0898ea4a00b644
Cr-Commit-Position: refs/heads/master@{#296879}

[Vitaly Buka (NO REVIEWS), 2014-09-24 17:42:22]

vitalybuka@chromium.org changed reviewers:
+ thestig@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-09-24 17:50:26]

vitalybuka@chromium.org changed reviewers:
+ joaodasilva@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-09-24 17:50:27]

+joaodasilva for components\policy\resources\policy_templates.json

[Lei Zhang, 2014-09-24 17:53:43]

lgtm

https://codereview.chromium.org/597933002/diff/80001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/597933002/diff/80001/build/common.gypi#newcod...
build/common.gypi:2883: 'defines': ['DISABLE_BASIC_PRINTING=1'],
accidental whitespace change?

https://codereview.chromium.org/597933002/diff/80001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/597933002/diff/80001/chrome/browser/ui/browse...
chrome/browser/ui/browser_commands.cc:864: if
(!browser->profile()->GetPrefs()->GetBoolean(prefs::kPrintPreviewDisabled)) {
nit: over 80 char / line

https://codereview.chromium.org/597933002/diff/80001/chrome/renderer/printing...
File chrome/renderer/printing/print_web_view_helper.h (left):

https://codereview.chromium.org/597933002/diff/80001/chrome/renderer/printing...
chrome/renderer/printing/print_web_view_helper.h:72: // Disable print preview
and switch to system dialog printing even if full
Not sure if you want to keep this around for CEF?

[Vitaly Buka (NO REVIEWS), 2014-09-24 18:07:03]

https://codereview.chromium.org/597933002/diff/80001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/597933002/diff/80001/build/common.gypi#newcod...
build/common.gypi:2883: 'defines': ['DISABLE_BASIC_PRINTING=1'],
On 2014/09/24 17:53:42, Lei Zhang wrote:
> accidental whitespace change?

We need to re-enable until we remove policy

https://codereview.chromium.org/597933002/diff/80001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/597933002/diff/80001/chrome/browser/ui/browse...
chrome/browser/ui/browser_commands.cc:864: if
(!browser->profile()->GetPrefs()->GetBoolean(prefs::kPrintPreviewDisabled)) {
On 2014/09/24 17:53:42, Lei Zhang wrote:
> nit: over 80 char / line

Done.

https://codereview.chromium.org/597933002/diff/80001/chrome/renderer/printing...
File chrome/renderer/printing/print_web_view_helper.h (left):

https://codereview.chromium.org/597933002/diff/80001/chrome/renderer/printing...
chrome/renderer/printing/print_web_view_helper.h:72: // Disable print preview
and switch to system dialog printing even if full
On 2014/09/24 17:53:43, Lei Zhang wrote:
> Not sure if you want to keep this around for CEF?

Done.

it duplicates kDisablePrintPreview, but we could keep it to avoid switching
back-and-forth on their side.

[Joao da Silva, 2014-09-25 10:08:49]

joaodasilva@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[Joao da Silva, 2014-09-25 10:08:50]

lgtm

Thanks for putting this back. I'm assuming this will be merged to 38?

(+pastarmovj for any further policy changed while I'm OOO)

[Vitaly Buka (NO REVIEWS), 2014-09-25 18:50:39]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-25 18:51:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597933002/140001

[commit-bot: I haz the power, 2014-09-25 18:57:11]

Committed patchset #8 (id:140001) as f0685ac521f428f05d9788d9e2088575e39c9859

[commit-bot: I haz the power, 2014-09-25 18:57:48]

Patchset 8 (id:??) landed as
https://crrev.com/15daa893f50daebf33ccf06ba67d74788700e495
Cr-Commit-Position: refs/heads/master@{#296751}

[Vitaly Buka (NO REVIEWS), 2014-09-25 23:35:29]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/603253003/ by vitalybuka@chromium.org.

The reason for reverting is: Noticed a bug in render_view_context_menu.cc
change.

[Vitaly Buka (NO REVIEWS), 2014-09-26 00:07:55]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-26 00:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597933002/220001

[Vitaly Buka (NO REVIEWS), 2014-09-26 01:04:03]

The CQ bit was unchecked by vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-09-26 04:05:22]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-26 04:06:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597933002/240001

[commit-bot: I haz the power, 2014-09-26 04:11:21]

Committed patchset #13 (id:240001) as c65235e0774305e16f76be785274e1b5b55cfd5d

[commit-bot: I haz the power, 2014-09-26 04:12:26]

Patchset 13 (id:??) landed as
https://crrev.com/a7ae5053246257da01d01120bf0898ea4a00b644
Cr-Commit-Position: refs/heads/master@{#296879}