Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: tools/clang/plugins/tests/virtual_methods.h

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add copyright blurb Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/virtual_bodies.txt ('k') | tools/clang/plugins/tests/virtual_methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/virtual_methods.h
diff --git a/tools/clang/plugins/tests/virtual_methods.h b/tools/clang/plugins/tests/virtual_methods.h
deleted file mode 100644
index d9fbf96ed328e241e7675f8b3efaa5249d5be776..0000000000000000000000000000000000000000
--- a/tools/clang/plugins/tests/virtual_methods.h
+++ /dev/null
@@ -1,39 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef VIRTUAL_METHODS_H_
-#define VIRTUAL_METHODS_H_
-
-// Should warn about virtual method usage.
-class VirtualMethodsInHeaders {
- public:
- // Don't complain about these.
- virtual void MethodIsAbstract() = 0;
- virtual void MethodHasNoArguments();
- virtual void MethodHasEmptyDefaultImpl() {}
-
- // But complain about this:
- virtual bool ComplainAboutThis() { return true; }
-};
-
-// Complain on missing 'virtual' keyword in overrides.
-class WarnOnMissingVirtual : public VirtualMethodsInHeaders {
- public:
- void MethodHasNoArguments() override;
-};
-
-// Don't complain about things in a 'testing' namespace.
-namespace testing {
-struct TestStruct {};
-} // namespace testing
-
-class VirtualMethodsInHeadersTesting : public VirtualMethodsInHeaders {
- public:
- // Don't complain about no virtual testing methods.
- void MethodHasNoArguments();
- private:
- testing::TestStruct tester_;
-};
-
-#endif // VIRTUAL_METHODS_H_
« no previous file with comments | « tools/clang/plugins/tests/virtual_bodies.txt ('k') | tools/clang/plugins/tests/virtual_methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698