Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: tools/clang/plugins/tests/virtual_methods.h

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add copyright blurb Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef VIRTUAL_METHODS_H_
6 #define VIRTUAL_METHODS_H_
7
8 // Should warn about virtual method usage.
9 class VirtualMethodsInHeaders {
10 public:
11 // Don't complain about these.
12 virtual void MethodIsAbstract() = 0;
13 virtual void MethodHasNoArguments();
14 virtual void MethodHasEmptyDefaultImpl() {}
15
16 // But complain about this:
17 virtual bool ComplainAboutThis() { return true; }
18 };
19
20 // Complain on missing 'virtual' keyword in overrides.
21 class WarnOnMissingVirtual : public VirtualMethodsInHeaders {
22 public:
23 void MethodHasNoArguments() override;
24 };
25
26 // Don't complain about things in a 'testing' namespace.
27 namespace testing {
28 struct TestStruct {};
29 } // namespace testing
30
31 class VirtualMethodsInHeadersTesting : public VirtualMethodsInHeaders {
32 public:
33 // Don't complain about no virtual testing methods.
34 void MethodHasNoArguments();
35 private:
36 testing::TestStruct tester_;
37 };
38
39 #endif // VIRTUAL_METHODS_H_
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/virtual_bodies.txt ('k') | tools/clang/plugins/tests/virtual_methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698