tools/clang/plugins/FindBadConstructsAction.cpp - Issue 597863002: Update plugin to handle new style rules for virtual annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/annotation/specifier/g Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/plugins/FindBadConstructsAction.cpp

diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp

index ccf7f6397f256d0c5dab4199213b12e79f4c4b77..027c0d42a74f42d4a9ab978b1aee09f0d5cc2ef1 100644

--- a/tools/clang/plugins/FindBadConstructsAction.cpp

+++ b/tools/clang/plugins/FindBadConstructsAction.cpp

@@ -36,6 +36,8 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,

// TODO(tsepez): Enable this by default once http://crbug.com/356815

// and http://crbug.com/356816 are fixed.

options_.check_enum_last_value = true;

+ } else if (args[0] == "strict-virtual-specifiers") {

hans 2014/09/26 01:29:29 args[i]?

dcheng 2014/09/26 07:07:13 Done.

+ options_.strict_virtual_specifiers = true;

} else {

parsed = false;

llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";

« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.h » ('j') | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('J')