Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 597863002: Update plugin to handle new style rules for virtual annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/annotation/specifier/g Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "FindBadConstructsAction.h" 5 #include "FindBadConstructsAction.h"
6 6
7 #include "clang/Frontend/FrontendPluginRegistry.h" 7 #include "clang/Frontend/FrontendPluginRegistry.h"
8 8
9 #include "FindBadConstructsConsumer.h" 9 #include "FindBadConstructsConsumer.h"
10 10
(...skipping 18 matching lines...) Expand all
29 if (args[i] == "check-base-classes") { 29 if (args[i] == "check-base-classes") {
30 // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed. 30 // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
31 options_.check_base_classes = true; 31 options_.check_base_classes = true;
32 } else if (args[i] == "check-weak-ptr-factory-order") { 32 } else if (args[i] == "check-weak-ptr-factory-order") {
33 // TODO(dmichael): Remove this once http://crbug.com/303818 is fixed. 33 // TODO(dmichael): Remove this once http://crbug.com/303818 is fixed.
34 options_.check_weak_ptr_factory_order = true; 34 options_.check_weak_ptr_factory_order = true;
35 } else if (args[i] == "check-enum-last-value") { 35 } else if (args[i] == "check-enum-last-value") {
36 // TODO(tsepez): Enable this by default once http://crbug.com/356815 36 // TODO(tsepez): Enable this by default once http://crbug.com/356815
37 // and http://crbug.com/356816 are fixed. 37 // and http://crbug.com/356816 are fixed.
38 options_.check_enum_last_value = true; 38 options_.check_enum_last_value = true;
39 } else if (args[0] == "strict-virtual-specifiers") {
hans 2014/09/26 01:29:29 args[i]?
dcheng 2014/09/26 07:07:13 Done.
40 options_.strict_virtual_specifiers = true;
39 } else { 41 } else {
40 parsed = false; 42 parsed = false;
41 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n"; 43 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
42 } 44 }
43 } 45 }
44 46
45 return parsed; 47 return parsed;
46 } 48 }
47 49
48 } // namespace chrome_checker 50 } // namespace chrome_checker
49 51
50 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( 52 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
51 "find-bad-constructs", 53 "find-bad-constructs",
52 "Finds bad C++ constructs"); 54 "Finds bad C++ constructs");
OLDNEW
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.h » ('j') | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698