Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 597853004: Revert of Turn off autofill highlight when changing option in an autofilled <select> element (Closed)

Created:
6 years, 3 months ago by Mads Ager (chromium)
Modified:
6 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Turn off autofill highlight when changing option in an autofilled <select> element (patchset #3 id:40001 of https://codereview.chromium.org/553983012/) Reason for revert: This makes the FormAutofillTest.ClearFormWithNodeContainingSelectOne browser_test fail. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=FormAutofillTest.ClearFormWithNodeContainingSelectOne&testType=browser_tests Original issue's description: > Turn off autofill highlight when changing option in an autofilled <select> element > > R=isherman@chromium.org, tkent@chromium.org > BUG=412311 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182528 TBR=isherman@chromium.org,tkent@chromium.org,ziran.sun@samsung.com NOTREECHECKS=true NOTRY=true BUG=412311 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182569

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -32 lines) Patch
M LayoutTests/fast/forms/autofilled.html View 1 6 chunks +1 line, -15 lines 0 comments Download
M LayoutTests/fast/forms/autofilled-expected.txt View 1 3 chunks +1 line, -5 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/autofilled-expected.txt View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 4 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mads Ager (chromium)
Created Revert of Turn off autofill highlight when changing option in an autofilled <select> element
6 years, 3 months ago (2014-09-24 07:23:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597853004/1
6 years, 3 months ago (2014-09-24 07:24:27 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-24 07:24:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597853004/80003
6 years, 3 months ago (2014-09-24 07:31:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 07:32:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:80003) as 182569

Powered by Google App Engine
This is Rietveld 408576698