extensions: Explicitly ignore result of CalledOnValidThread().

extensions: Explicitly ignore result of CalledOnValidThread().

BUG=314505
Committed: https://crrev.com/7fb8b9950da0f1156d07e18dca5151f3f1457e2b
Cr-Commit-Position: refs/heads/master@{#296640}

[anujsharma, 2014-09-24 07:57:40]

anujk.sharma@samsung.com changed reviewers:
+ finnur@chromium.org

[anujsharma, 2014-09-24 07:57:40]

PTAL

[Finnur, 2014-09-24 11:02:37]

finnur@chromium.org changed reviewers:
+ thakis@chromium.org
- finnur@chromium.org

[Finnur, 2014-09-24 11:11:00]

I'm not sure why you chose me for this review given that I'm not familiar with
this file nor an OWNER for the directory, so my word doesn't count for much on
this.

I'd pick either Ken Rockot or Nico Weber (thakis) and since Nico has been active
in making this kind of change I'd put him as reviewer and Ken in for an OWNERS
check. Note that both will be slow to respond this week.

> // CalledOnValidThread is the only available API to reassociate
> // thread_checker_ with the current thread. Result ignored intentionally.

This seems counter-intuitive and given that we do this in more than once place:
Do we need to provide an API for this explicitly?


Note to reviewers: I've confirmed the email has signed the CLA and is listed in
AUTHORS (so you don't need to duplicate that work).

[anujsharma, 2014-09-24 11:35:27]

anujk.sharma@samsung.com changed reviewers:
+ rockot@chromium.org

[anujsharma, 2014-09-24 11:35:27]

rockot@chromium.org: Please review changes in extensions

[Ken Rockot(use gerrit already), 2014-09-24 17:14:12]

I think this isn't correct, and neither was the code before this change.

The line in question should actually be a DCHECK, not an ignored result. Reilly,
do you agree?

[Reilly Grant (use Gerrit), 2014-09-24 17:18:40]

I agree with Ken. This should be a DCHECK.

[anujsharma, 2014-09-25 03:00:08]

On 2014/09/24 17:18:40, reillyg wrote:
> I agree with Ken. This should be a DCHECK.

Thanks Ken and reillyg for your kind review and suggestion.
Modified the CL as per your suggestion and added a DCHECK.

PTAL

Thanks!!

[Ken Rockot(use gerrit already), 2014-09-25 03:02:25]

lgtm

[anujsharma, 2014-09-25 03:03:22]

On 2014/09/25 03:02:25, Ken Rockot (slow this week) wrote:
> lgtm

Thanks Ken for lgtm

[anujsharma, 2014-09-25 03:04:52]

The CQ bit was checked by anujk.sharma@samsung.com

[commit-bot: I haz the power, 2014-09-25 03:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597853003/40002

[commit-bot: I haz the power, 2014-09-25 04:22:23]

Committed patchset #5 (id:40002) as 2b613e4f49ac58dae9ac9e9c19cb7e39472d776b

[commit-bot: I haz the power, 2014-09-25 04:23:25]

Patchset 5 (id:??) landed as
https://crrev.com/7fb8b9950da0f1156d07e18dca5151f3f1457e2b
Cr-Commit-Position: refs/heads/master@{#296640}