extensions/browser/api/hid/hid_device_manager.cc - Issue 597853003: extensions: Explicitly ignore result of CalledOnValidThread().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_device_manager.cc

Issue 597853003: extensions: Explicitly ignore result of CalledOnValidThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding DCHECK to thread_checker_.CalledOnValidThread() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/hid/hid_device_manager.cc

diff --git a/extensions/browser/api/hid/hid_device_manager.cc b/extensions/browser/api/hid/hid_device_manager.cc

index 1c2502591e46867cfcdc047dbfd6173bc9b3a361..7de56b4bf816bd979cca0ae150b45eb55d31cfeb 100644

--- a/extensions/browser/api/hid/hid_device_manager.cc

+++ b/extensions/browser/api/hid/hid_device_manager.cc

@@ -143,7 +143,7 @@ bool HidDeviceManager::HasPermission(const Extension* extension,

}

void HidDeviceManager::UpdateDevices() {

- thread_checker_.CalledOnValidThread();

+ DCHECK(thread_checker_.CalledOnValidThread());

HidService* hid_service = device::DeviceClient::Get()->GetHidService();

DCHECK(hid_service);

« no previous file with comments | « no previous file | no next file » | no next file with comments »