Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 597803002: [Easy Unlock] Update strings to inform users about Bluetooth use and to tell a clearer story. (Closed)

Created:
6 years, 3 months ago by Ilya Sherman
Modified:
6 years, 2 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Easy Unlock] Update strings to inform users about Bluetooth use and to tell a clearer story. BUG=409100 R=tengs@chromium.org Committed: https://crrev.com/1459abf9108520dcd3bc4b42fd2703bbb9582965 Cr-Commit-Position: refs/heads/master@{#296756}

Patch Set 1 #

Patch Set 2 : Set the user's display email address #

Patch Set 3 : Fix compile on non-ChromeOS platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M chrome/app/generated_resources.grd View 6 chunks +22 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 2 4 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Ilya Sherman
This CL is mostly complete. The one missing piece that I'm aware of is setting ...
6 years, 3 months ago (2014-09-24 00:32:39 UTC) #1
Ilya Sherman
Now fully complete.
6 years, 3 months ago (2014-09-24 21:51:55 UTC) #2
Tim Song
lgtm
6 years, 3 months ago (2014-09-24 22:11:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597803002/20001
6 years, 3 months ago (2014-09-24 22:13:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/18737) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/19522) mac_chromium_compile_dbg ...
6 years, 3 months ago (2014-09-24 22:40:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597803002/20001
6 years, 2 months ago (2014-09-25 17:34:18 UTC) #9
Ilya Sherman
*sigh*, I ran an upload+commit command for this CL yesterday as I was leaving, but ...
6 years, 2 months ago (2014-09-25 18:04:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597803002/40001
6 years, 2 months ago (2014-09-25 18:05:01 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 45ae5213b40652743ca918b27c21ff81d20e7ee9
6 years, 2 months ago (2014-09-25 19:16:07 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 19:17:20 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1459abf9108520dcd3bc4b42fd2703bbb9582965
Cr-Commit-Position: refs/heads/master@{#296756}

Powered by Google App Engine
This is Rietveld 408576698