extensions/browser/api/web_view/web_view_internal_api.cc - Issue 597753003: Implement find in page support for top level BrowserPlugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_view/web_view_internal_api.cc

Issue 597753003: Implement find in page support for top level BrowserPlugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h » ('j') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_view/web_view_internal_api.cc

diff --git a/extensions/browser/api/web_view/web_view_internal_api.cc b/extensions/browser/api/web_view/web_view_internal_api.cc

index c6ed1ce79feac19142725755c0f7cf87516b0eda..781f158969e66cd7c3edd6d218819daccb17c081 100644

--- a/extensions/browser/api/web_view/web_view_internal_api.cc

+++ b/extensions/browser/api/web_view/web_view_internal_api.cc

@@ -266,7 +266,7 @@ bool WebViewInternalFindFunction::RunAsyncSafe(WebViewGuest* guest) {

params->options->match_case ? *params->options->match_case : false;

}

- guest->Find(search_text, options, this);

+ guest->StartFinding(search_text, options, this);

return true;

}