content/renderer/browser_plugin/browser_plugin.cc - Issue 597753003: Implement find in page support for top level BrowserPlugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 597753003: Implement find in page support for top level BrowserPlugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/browser_plugin_guest_delegate.cc ('k') | extensions/browser/api/web_view/web_view_internal_api.cc » ('j') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.cc

diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc

index b51b452161e21addcbdd5addba00153b3615874c..82c9e25738d50696fe9844f1e3661052a8663b1e 100644

--- a/content/renderer/browser_plugin/browser_plugin.cc

+++ b/content/renderer/browser_plugin/browser_plugin.cc

@@ -22,8 +22,10 @@

#include "content/renderer/render_thread_impl.h"

#include "content/renderer/sad_plugin.h"

#include "third_party/WebKit/public/platform/WebRect.h"

+#include "third_party/WebKit/public/web/WebDocument.h"

#include "third_party/WebKit/public/web/WebElement.h"

#include "third_party/WebKit/public/web/WebInputEvent.h"

+#include "third_party/WebKit/public/web/WebLocalFrame.h"

#include "third_party/WebKit/public/web/WebPluginContainer.h"

#include "third_party/WebKit/public/web/WebView.h"

#include "third_party/skia/include/core/SkCanvas.h"

@@ -140,6 +142,12 @@ void BrowserPlugin::Attach() {

attach_params.focused = ShouldGuestBeFocused();

attach_params.visible = visible_;

attach_params.origin = plugin_rect().origin();

+ attach_params.is_full_page_plugin = false;

+ if (container()) {

+ blink::WebLocalFrame* frame = container()->element().document().frame();

+ attach_params.is_full_page_plugin =

+ frame->view()->mainFrame()->document().isPluginDocument();

+ }

gfx::Size view_size(width(), height());

if (!view_size.IsEmpty()) {

PopulateResizeGuestParameters(view_size,