Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 597673003: [Search] Make the feature name link to a learn more screen in the first-run experience. (Closed)

Created:
6 years, 3 months ago by Mathieu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Search] Make the feature name link to a learn more screen in the first-run experience. Updated wording as well. BUG=413337 TEST=manual Committed: https://crrev.com/f880c8c0ec0052bbe72ab0574372713177a8edb5 Cr-Commit-Position: refs/heads/master@{#296441}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/contextual_search/promo.css View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/contextual_search/promo.html View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/search/contextual_search_promo_source_android.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Mathieu
Hello, Please have a look!
6 years, 3 months ago (2014-09-23 19:17:14 UTC) #2
pedro (no code reviews)
On 2014/09/23 19:17:14, Mathieu Perreault wrote: > Hello, > > Please have a look! It ...
6 years, 3 months ago (2014-09-24 02:08:09 UTC) #3
pedro (no code reviews)
lgtm https://codereview.chromium.org/597673003/diff/20001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/597673003/diff/20001/chrome/app/chromium_strings.grd#newcode1209 chrome/app/chromium_strings.grd:1209: Using Let's update this with the new message.
6 years, 3 months ago (2014-09-24 02:08:27 UTC) #4
pedro (no code reviews)
Left you one more nit :) https://codereview.chromium.org/597673003/diff/20001/chrome/browser/resources/contextual_search/promo.html File chrome/browser/resources/contextual_search/promo.html (right): https://codereview.chromium.org/597673003/diff/20001/chrome/browser/resources/contextual_search/promo.html#newcode19 chrome/browser/resources/contextual_search/promo.html:19: <a class="colored" href="#settings" ...
6 years, 3 months ago (2014-09-24 02:30:56 UTC) #5
Mathieu
Done. https://codereview.chromium.org/597673003/diff/20001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/597673003/diff/20001/chrome/app/chromium_strings.grd#newcode1209 chrome/app/chromium_strings.grd:1209: Using On 2014/09/24 02:08:27, pedrosimonetti wrote: > Let's ...
6 years, 3 months ago (2014-09-24 15:37:50 UTC) #6
huangs
lgtm
6 years, 3 months ago (2014-09-24 15:43:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597673003/40001
6 years, 3 months ago (2014-09-24 15:46:32 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4f72f08d89b78565d215de58f7007b880fda0b57
6 years, 3 months ago (2014-09-24 16:47:11 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 16:47:54 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f880c8c0ec0052bbe72ab0574372713177a8edb5
Cr-Commit-Position: refs/heads/master@{#296441}

Powered by Google App Engine
This is Rietveld 408576698